Remove the "remove_error_details" change #15331

areshand · 2024-11-20T17:31:20Z

Description

withdrew this change due to negative ecosystem impact after the discussion

How Has This Been Tested?

Existing tests

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-20T17:31:23Z

⏱️ 8h 49m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	3h 19m	🟥 🟩 🟩 🟩 🟩 (+4 more)
test-target-determinator	41m	🟩 🟩 🟩 🟩 🟩 (+4 more)
execution-performance / test-target-determinator	39m	🟩 🟩 🟩 🟩 🟩 (+4 more)
check	33m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-cargo-deny	22m	🟩 🟩 🟩 🟩 🟩 (+8 more)
fetch-last-released-docker-image-tag	15m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-tests	14m	🟥 🟥
check-dynamic-deps	13m	🟩 🟩 🟩 🟩 🟩 (+8 more)
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-move-tests	9m	🟥
rust-move-tests	8m	🟥
rust-move-tests	8m	🟥
rust-move-tests	7m	🟥
rust-move-tests	7m	🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	26m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

graphite-app · 2024-11-21T22:35:27Z

storage/aptosdb/src/db/include/aptosdb_writer.rs

@@ -489,6 +483,7 @@ impl AptosDB {
        Ok(root_hash)
    }

+    #[allow(dead_code)]


The #[allow(dead_code)] annotation appears incorrect since commit_transaction_auxiliary_data() is called in the commit_chunk_impl() method. Consider removing this annotation or documenting why this function appears unused if there are special circumstances around its usage pattern.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

types/src/transaction/mod.rs

georgemitenkov · 2024-11-21T23:34:37Z

types/src/on_chain_config/aptos_features.rs

@@ -163,7 +163,6 @@ impl FeatureFlag {
            FeatureFlag::COIN_TO_FUNGIBLE_ASSET_MIGRATION,
            FeatureFlag::OBJECT_NATIVE_DERIVED_ADDRESS,
            FeatureFlag::DISPATCHABLE_FUNGIBLE_ASSET,
-            FeatureFlag::REMOVE_DETAILED_ERROR_FROM_HASH,


can we also remove is_remove_detailed_error_from_hash_enabled? Also we can rename the feature flag to indicate this is unused?

we probably shouldn't remove feature and thus its corresponding functions. I added a comment to indicate this feature is not used.

nit: I think you can just call the feature flag as _DEPRECATED_... - we already have this for transaction fees and DKG feature flags. Better than the comment because it is explicitly deprecated. I would still prefer to remove is_remove_detailed_error_from_hash_enabled because if feature is removed, it should not have public APIs

storage/aptosdb/src/db/include/aptosdb_writer.rs

aptos-move/e2e-testsuite/proptest-regressions/tests/account_universe/peer_to_peer.txt

types/src/transaction/mod.rs

aptos-move/aptos-vm/src/aptos_vm.rs

georgemitenkov

Approved by mistake, want to comment only😄 requesting changes to override

georgemitenkov

LGTM, just one small comment. Please make sure all tests pass - I see some Move related tests still fail due to missing error statuses

georgemitenkov · 2024-11-25T10:14:51Z

types/src/on_chain_config/aptos_features.rs

@@ -163,7 +163,6 @@ impl FeatureFlag {
            FeatureFlag::COIN_TO_FUNGIBLE_ASSET_MIGRATION,
            FeatureFlag::OBJECT_NATIVE_DERIVED_ADDRESS,
            FeatureFlag::DISPATCHABLE_FUNGIBLE_ASSET,
-            FeatureFlag::REMOVE_DETAILED_ERROR_FROM_HASH,


nit: I think you can just call the feature flag as _DEPRECATED_... - we already have this for transaction fees and DKG feature flags. Better than the comment because it is explicitly deprecated. I would still prefer to remove is_remove_detailed_error_from_hash_enabled because if feature is removed, it should not have public APIs

github-actions · 2024-11-26T21:33:22Z

❌ Forge suite `framework_upgrade` failure on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `4955ab9406cd7db29f849886f6b5a3b66b01444a`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 4955ab9406cd7db29f849886f6b5a3b66b01444a (PR)
Upgrade the nodes to version: 4955ab9406cd7db29f849886f6b5a3b66b01444a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 103.99 txn/s, submitted: 134.42 txn/s, failed submission: 0.32 txn/s, expired: 30.43 txn/s, latency: 1832.78 ms, (p50: 1800 ms, p70: 2300, p90: 2900 ms, p99: 4100 ms), latency samples: 32199
Test Failed: Waiting for nodes to catch up to target version and epoch (None, Some(9)) timed out after 20 seconds, current status: Ok([("validator-0", 33335, 8), ("validator-1", 33335, 8), ("validator-2", 33335, 8), ("validator-3", 33335, 8)])

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_target_version_or_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:463:24
   2: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:396:6
   3: aptos_forge::interface::swarm::SwarmExt::wait_for_all_nodes_to_change_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:289:92
   4: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   5: aptos_forge::interface::swarm::SwarmExt::fork_check::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:200:14
   6: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: <aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/framework_upgrade.rs:93:63
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  10: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  11: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  12: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  13: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  14: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  15: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  16: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  17: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  18: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:332:50
  19: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
  20: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
  21: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  22: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  23: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  24: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  25: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  26: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  27: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  28: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  29: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start
Trailing Log Lines:
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="1" errors="0" uuid="91c90489-1c1b-406c-af50-fefdfc8ed5bb">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="1">
        <testcase name="framework_upgrade::framework-upgrade">
            <failure message="Waiting for nodes to catch up to target version and epoch (None, Some(9)) timed out after 20 seconds, current status: Ok([(&quot;validator-0&quot;, 33335, 8), (&quot;validator-1&quot;, 33335, 8), (&quot;validator-2&quot;, 33335, 8), (&quot;validator-3&quot;, 33335, 8)])

Stack backtrace:
   0: anyhow::error::&lt;impl anyhow::Error&gt;::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_target_version_or_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:463:24
   2: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:396:6
   3: aptos_forge::interface::swarm::SwarmExt::wait_for_all_nodes_to_change_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:289:92
   4: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   5: aptos_forge::interface::swarm::SwarmExt::fork_check::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:200:14
   6: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: &lt;aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/framework_upgrade.rs:93:63
   8: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  10: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  11: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  12: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  13: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  14: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  15: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  16: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  17: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  18: aptos_forge::runner::Forge&lt;F&gt;::run
             at ./testsuite/forge/src/runner.rs:332:50
  19: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
  20: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
  21: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  22: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  23: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  24: core::ops::function::impls::&lt;impl core::ops::function::FnOnce&lt;A&gt; for &amp;F&gt;::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  25: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  26: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  27: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  28: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  29: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start"/>
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===

Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:381"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-15331-1732656230-010570d3b7aa20889fb","timestamp":"2024-11-26T21:33:18.269143Z","message":"Deleting namespace forge-framework-upgrade-pr-15331: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:398"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-15331-1732656230-010570d3b7aa20889fb","timestamp":"2024-11-26T21:33:18.269173Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-15331"}
Failed to run tests:
Tests Failed

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Error: Tests Failed

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:358:13
   2: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
   3: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
   5: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
   6: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
   7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
   8: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
   9: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  10: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  12: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  15: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  16: main
  17: __libc_start_main
  18: _start
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                1/1     Running     0          6m59s
aptos-node-1-validator-0                1/1     Running     0          6m16s
aptos-node-2-validator-0                1/1     Running     0          9m6s
aptos-node-3-validator-0                1/1     Running     0          9m6s
forge-testnet-deployer-zn5dn            0/1     Completed   0          9m14s
genesis-aptos-genesis-eforge149-2nc9k   0/1     Completed   0          9m7s

github-actions · 2024-11-26T21:36:33Z

✅ Forge suite `realistic_env_max_load` success on `4955ab9406cd7db29f849886f6b5a3b66b01444a`

two traffics test: inner traffic : committed: 13988.39 txn/s, latency: 2841.62 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 6300 ms), latency samples: 5318700
two traffics test : committed: 100.03 txn/s, latency: 2627.13 ms, (p50: 1600 ms, p70: 2100, p90: 4500 ms, p99: 17700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.067, avg: 1.266", "ConsensusProposalToOrdered: max: 0.328, avg: 0.296", "ConsensusOrderedToCommit: max: 0.381, avg: 0.366", "ConsensusProposalToCommit: max: 0.672, avg: 0.663"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.16s no progress at version 1856881 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.26s no progress at version 1856879 (avg 15.12s) [limit 16].
Test Ok

github-actions · 2024-11-26T21:39:39Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `4955ab9406cd7db29f849886f6b5a3b66b01444a`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 4955ab9406cd7db29f849886f6b5a3b66b01444a (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 15354.67 txn/s, latency: 2199.14 ms, (p50: 2100 ms, p70: 2200, p90: 2500 ms, p99: 4500 ms), latency samples: 498000
2. Upgrading first Validator to new version: 4955ab9406cd7db29f849886f6b5a3b66b01444a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7782.91 txn/s, latency: 3666.68 ms, (p50: 4100 ms, p70: 4300, p90: 4400 ms, p99: 4400 ms), latency samples: 144080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7853.55 txn/s, latency: 4095.93 ms, (p50: 4300 ms, p70: 4500, p90: 5700 ms, p99: 5800 ms), latency samples: 257640
3. Upgrading rest of first batch to new version: 4955ab9406cd7db29f849886f6b5a3b66b01444a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7236.15 txn/s, latency: 3915.79 ms, (p50: 4400 ms, p70: 4600, p90: 4800 ms, p99: 4800 ms), latency samples: 132300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7127.15 txn/s, latency: 4537.34 ms, (p50: 4900 ms, p70: 5100, p90: 5800 ms, p99: 6500 ms), latency samples: 238740
4. upgrading second batch to new version: 4955ab9406cd7db29f849886f6b5a3b66b01444a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11278.32 txn/s, latency: 2475.88 ms, (p50: 2500 ms, p70: 2800, p90: 3200 ms, p99: 3300 ms), latency samples: 194540
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10915.74 txn/s, latency: 2887.79 ms, (p50: 2600 ms, p70: 3100, p90: 4800 ms, p99: 5600 ms), latency samples: 354260
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 4955ab9406cd7db29f849886f6b5a3b66b01444a passed
Test Ok

areshand requested review from msmouse and grao1991 November 20, 2024 17:31

areshand force-pushed the deprecate_related_changes branch from 6257556 to 86056a3 Compare November 21, 2024 18:23

areshand requested review from lightmark, davidiw, wrwg, zekun000, vgao1996 and georgemitenkov as code owners November 21, 2024 18:23

areshand changed the title ~~Remove error detail from default feature list~~ Remove the "remove_error_details" change Nov 21, 2024

areshand force-pushed the deprecate_related_changes branch 2 times, most recently from 632487e to 0f9c1d0 Compare November 21, 2024 19:10

areshand enabled auto-merge (rebase) November 21, 2024 19:11